Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect pxd typing for for _marshall #75

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 5, 2022

The typing was not correct. The type on a few of the message functions needed to be adjusted as well as they were not correct either.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 81.32% // Head: 81.32% // No change to project coverage 👍

Coverage data is based on head (1b07d5a) compared to base (8676f12).
Patch coverage: 92.30% of modified lines in pull request are covered.

❗ Current head 1b07d5a differs from pull request most recent head eb75ac8. Consider uploading reports for the commit eb75ac8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files          25       25           
  Lines        2923     2923           
  Branches      567      567           
=======================================
  Hits         2377     2377           
  Misses        335      335           
  Partials      211      211           
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/aio/message_bus.py 87.61% <100.00%> (ø)
src/dbus_fast/glib/message_bus.py 81.06% <100.00%> (ø)
src/dbus_fast/message.py 95.50% <100.00%> (ø)
src/dbus_fast/validators.py 83.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco changed the title fix: type for _marshall in pxd fix: incorrect pxd typing for for _marshall Oct 6, 2022
@bdraco bdraco merged commit cf1f012 into main Oct 6, 2022
@bdraco bdraco deleted the fix_pxd_message branch October 6, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant